Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Thu, 13 Nov 2014 03:55:33 +0000 (UTC)
From: "zhihai xu (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12752338.1414964421000.487807.1415850933856@Atlassian.JIRA>
In-Reply-To: <JIRA.12752338.1414964421000@Atlassian.JIRA>
References: <JIRA.12752338.1414964421000@Atlassian.JIRA>
 <JIRA.12752338.1414964421331@arcas>
Subject: [jira] [Updated] (YARN-2799) cleanup TestLogAggregationService
 based on the change in YARN-90
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/YARN-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

zhihai xu updated YARN-2799:
----------------------------
    Attachment: YARN-2799.001.patch

> cleanup TestLogAggregationService based on the change in YARN-90
> ----------------------------------------------------------------
>
>                 Key: YARN-2799
>                 URL: https://issues.apache.org/jira/browse/YARN-2799
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: test
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>            Priority: Minor
>         Attachments: YARN-2799.000.patch, YARN-2799.001.patch
>
>
> cleanup TestLogAggregationService based on the change in YARN-90.
> The following code is added to setup in YARN-90, 
> {code}
>     dispatcher = createDispatcher();
>     appEventHandler = mock(EventHandler.class);
>     dispatcher.register(ApplicationEventType.class, appEventHandler);
> {code}
> In this case, we should remove all these code from each test function to avoid duplicate code.
> Same for dispatcher.stop() which is in tearDown,
> we can remove dispatcher.stop() from from each test function also because it will always be called from tearDown for each test.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)