Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 44D6DCA34 for ; Sat, 15 Nov 2014 21:09:34 +0000 (UTC) Received: (qmail 37028 invoked by uid 500); 15 Nov 2014 21:09:34 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 36963 invoked by uid 500); 15 Nov 2014 21:09:34 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 36950 invoked by uid 99); 15 Nov 2014 21:09:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 15 Nov 2014 21:09:34 +0000 Date: Sat, 15 Nov 2014 21:09:33 +0000 (UTC) From: "Vinod Kumar Vavilapalli (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-2675) the containersKilled metrics is not updated when the container is killed during localization. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213761#comment-14213761 ] Vinod Kumar Vavilapalli commented on YARN-2675: ----------------------------------------------- I admit it's not caused by your patch, but the fact that we have to catch 'default' and log error without any action tells me this is broken. I think we should dismantle the finished() method altogether and directly have separate transitions which sub-class ContainerDoneTransition and do the right thing w.r.t metrics for that specific transition. Can we do that here? > the containersKilled metrics is not updated when the container is killed during localization. > --------------------------------------------------------------------------------------------- > > Key: YARN-2675 > URL: https://issues.apache.org/jira/browse/YARN-2675 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager > Affects Versions: 2.5.0 > Reporter: zhihai xu > Assignee: zhihai xu > Attachments: YARN-2675.000.patch, YARN-2675.001.patch, YARN-2675.002.patch > > > The containersKilled metrics is not updated when the container is killed during localization. We should add KILLING state in finished of ContainerImpl.java to update killedContainer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)