Return-Path: 
 <yarn-issues-return-41775-apmail-hadoop-yarn-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 3DAD917954
	for <apmail-hadoop-yarn-issues-archive@minotaur.apache.org>;
 Fri, 21 Nov 2014 22:31:34 +0000 (UTC)
Received: (qmail 71206 invoked by uid 500); 21 Nov 2014 22:31:34 -0000
Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org
Received: (qmail 71154 invoked by uid 500); 21 Nov 2014 22:31:34 -0000
Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:yarn-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:yarn-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:yarn-issues@hadoop.apache.org>
List-Id: <yarn-issues.hadoop.apache.org>
Reply-To: yarn-issues@hadoop.apache.org
Delivered-To: mailing list yarn-issues@hadoop.apache.org
Received: (qmail 71140 invoked by uid 99); 21 Nov 2014 22:31:34 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Nov 2014 22:31:34 +0000
Date: Fri, 21 Nov 2014 22:31:33 +0000 (UTC)
From: "Sandy Ryza (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12747086.1412878718000.556799.1416609093981@Atlassian.JIRA>
In-Reply-To: <JIRA.12747086.1412878718000@Atlassian.JIRA>
References: <JIRA.12747086.1412878718000@Atlassian.JIRA>
 <JIRA.12747086.1412878718437@arcas>
Subject: [jira] [Commented] (YARN-2669) FairScheduler: queueName shouldn't
 allow periods the allocation.xml
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/YARN-2669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14221513#comment-14221513 ] 

Sandy Ryza commented on YARN-2669:
----------------------------------

This is looking good.  A few comments.

Can we add documentation for this behavior in FairScheduler.apt.vm?

We should be doing the same conversion for group names, right?

{code}
+          + " submitted by user " + user + " with an illegal queue name ("
+          + queueName + "). "
{code}
Nit: I think it's better not to surround the queue name with parentheses.

{code}
+        return queueName + "." + convertUsername(user);
{code}
Can we call convertUsername something like cleanUsername to be a little more descriptive?

> FairScheduler: queueName shouldn't allow periods the allocation.xml
> -------------------------------------------------------------------
>
>                 Key: YARN-2669
>                 URL: https://issues.apache.org/jira/browse/YARN-2669
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Wei Yan
>            Assignee: Wei Yan
>            Priority: Minor
>         Attachments: YARN-2669-1.patch, YARN-2669-2.patch, YARN-2669-3.patch, YARN-2669-4.patch
>
>
> For an allocation file like:
> {noformat}
> <allocations>
>   <queue name="root.q1">
>     <minResources>4096mb,4vcores</minResources>
>   </queue>
> </allocations>
> {noformat}
> Users may wish to config minResources for a queue with full path "root.q1". However, right now, fair scheduler will treat this configureation for the queue with full name "root.root.q1". We need to print out a warning msg to notify users about this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)