Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Fri, 21 Nov 2014 19:55:34 +0000 (UTC)
From: "Wangda Tan (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12738746.1409734418000.555892.1416599734547@Atlassian.JIRA>
In-Reply-To: <JIRA.12738746.1409734418000@Atlassian.JIRA>
References: <JIRA.12738746.1409734418000@Atlassian.JIRA>
 <JIRA.12738746.1409734418612@arcas>
Subject: [jira] [Commented] (YARN-2495) Allow admin specify labels from each
 NM (Distributed configuration)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14221342#comment-14221342 ] 

Wangda Tan commented on YARN-2495:
----------------------------------

Hi [~Naganarasimha],
Thanks for update,
Several minor comments,
1) As same as ResourceTrackerService, it's better to have a field like isDecentralizedNodeLabelConfigurationEnabled (or some other name you like) in NodeStatusUpdaterImpl. Should be more clear than statement like
{code}
+            if (nodeLabelsProvider!=null) {
{code}

2) In ResourceTrackerService,
The message:
{code}
     String message =
         "NodeManager from node " + host + "(cmPort: " + cmPort + " httpPort: "
             + httpPort + ") " + "registered with capability: " + capability
-            + ", assigned nodeId " + nodeId;
+            + ", assigned nodeId " + nodeId + ", node labels { "
+            + StringUtils.join(",", nodeLabels) + " } ";
{code}
Should add a check, only logging node labels message when replace is succeeded. Ideally you should have a StringBuilder do this

3) A style suggestion is, as convention, bi-opts like "=", "!=", "+", etc. should leave a space between and after it. I can see several occurrences in the patch.

Wangda

> Allow admin specify labels from each NM (Distributed configuration)
> -------------------------------------------------------------------
>
>                 Key: YARN-2495
>                 URL: https://issues.apache.org/jira/browse/YARN-2495
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Naganarasimha G R
>         Attachments: YARN-2495.20141023-1.patch, YARN-2495.20141024-1.patch, YARN-2495.20141030-1.patch, YARN-2495.20141031-1.patch, YARN-2495.20141119-1.patch, YARN-2495_20141022.1.patch
>
>
> Target of this JIRA is to allow admin specify labels in each NM, this covers
> - User can set labels in each NM (by setting yarn-site.xml or using script suggested by [~aw])
> - NM will send labels to RM via ResourceTracker API
> - RM will set labels in NodeLabelManager when NM register/update labels


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)