Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Sat, 15 Nov 2014 14:19:37 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12735352.1408523633000.508735.1416061177743@Atlassian.JIRA>
In-Reply-To: <JIRA.12735352.1408523633000@Atlassian.JIRA>
References: <JIRA.12735352.1408523633000@Atlassian.JIRA>
 <JIRA.12735352.1408523633611@arcas>
Subject: [jira] [Commented] (YARN-2432) RMStateStore should process the
 pending events before close
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213625#comment-14213625 ] 

Hudson commented on YARN-2432:
------------------------------

SUCCESS: Integrated in Hadoop-Hdfs-trunk #1934 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1934/])
YARN-2432. RMStateStore should process the pending events before close. Contributed by Varun Saxena (jianhe: rev 9b860661a5754e829bd8c34ef092757421589bbe)
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java
* hadoop-yarn-project/CHANGES.txt


> RMStateStore should process the pending events before close
> -----------------------------------------------------------
>
>                 Key: YARN-2432
>                 URL: https://issues.apache.org/jira/browse/YARN-2432
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>             Fix For: 2.7.0
>
>         Attachments: YARN-2432.patch
>
>
> Refer to discussion on YARN-2136 (https://issues.apache.org/jira/browse/YARN-2136?focusedCommentId=14097266&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14097266). 
> As pointed out by [~jianhe], we should process the dispatcher event queue before closing the state store by flipping over the following statements in code.
> {code:title=RMStateStore.java|borderStyle=solid}
>  protected void serviceStop() throws Exception {
>     closeInternal();
>     dispatcher.stop();
>   }
> {code}
> Currently, if the state store is being stopped on events such as switching to standby, it will first close the state store(in case of ZKRMStateStore, close connection with ZK) and then process the pending events. Instead, we should first process the pending events and then call close.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)