Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 90DE510DC7 for ; Tue, 25 Nov 2014 03:24:14 +0000 (UTC) Received: (qmail 89517 invoked by uid 500); 25 Nov 2014 03:24:13 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 89469 invoked by uid 500); 25 Nov 2014 03:24:13 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 89458 invoked by uid 99); 25 Nov 2014 03:24:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Nov 2014 03:24:13 +0000 Date: Tue, 25 Nov 2014 03:24:13 +0000 (UTC) From: "Tsuyoshi OZAWA (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-2025) Possible NPE in schedulers#addApplicationAttempt() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-2025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223993#comment-14223993 ] Tsuyoshi OZAWA commented on YARN-2025: -------------------------------------- Thanks for your point, [~rohithsharma]. I'll take a look. > Possible NPE in schedulers#addApplicationAttempt() > -------------------------------------------------- > > Key: YARN-2025 > URL: https://issues.apache.org/jira/browse/YARN-2025 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Tsuyoshi OZAWA > Assignee: Tsuyoshi OZAWA > Attachments: YARN-2025.1.patch > > > In FifoScheduler/FairScheduler/CapacityScheduler#addApplicationAttempt(), we don't check whether {{application}} is null. This can cause NPE in following sequences: addApplication() -> doneApplication() (e.g. AppKilledTransition) -> addApplicationAttempt(). > {code} > SchedulerApplication application = > applications.get(applicationAttemptId.getApplicationId()); > String user = application.getUser(); > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)