hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Subru Krishnan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2881) Implement PlanFollower for FairScheduler
Date Sat, 22 Nov 2014 01:20:34 GMT

    [ https://issues.apache.org/jira/browse/YARN-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14221695#comment-14221695
] 

Subru Krishnan commented on YARN-2881:
--------------------------------------

[~adhoot], thanks for the  patch. It's good to see that majority of the code can be reused
between both Fair & Capacity Scheduler.

A few comments:
  * Are you assuming that parent queue names are unique in FS?
  * _run()_ need not be synchronized. I know this is from previous code but it would be good
to clean it up since we are refactoring the code.
  * _getChildReservationQueues()_ could be implemented by the _AbstractSchedulerPlanFollower_
using _Queue::getQueueInfo_ ?
  * I think we can add a _getResourceCalculator_ to _YarnScheduler_ as it makes sense. Then
we need not override _calculateTargetCapacity()_ and _isPlanResourcesLessThanReservations()_.
  * Minor: spurious white lines in imports of _CapacitySchedulerPlanFollower_ & _FairSchedulerPlanFollower_.

We should be able to see reservation system running end2end with this patch in conjunction
with YARN-2378.


> Implement PlanFollower for FairScheduler
> ----------------------------------------
>
>                 Key: YARN-2881
>                 URL: https://issues.apache.org/jira/browse/YARN-2881
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: fairscheduler
>            Reporter: Anubhav Dhoot
>            Assignee: Anubhav Dhoot
>         Attachments: YARN-2881.prelim.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message