hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig Welch (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2786) Create yarn cluster CLI to enable list node labels collection
Date Mon, 03 Nov 2014 21:28:34 GMT

    [ https://issues.apache.org/jira/browse/YARN-2786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14195131#comment-14195131

Craig Welch commented on YARN-2786:

The "node" command isn't a good fit for this aspect of node-labels, as it is not an operation
or query on nodes as such, but on the set of node labels recognized by the cluster.  If we
don't want to tie it to the resource manager (not sure we can't, but it sounds as though we
want to keep it distinct) then we need something new.  I actually preferred the original "node-labels"
command, but "cluster" is ok if we believe that other things will come along in the future
which fit this definition (and I could see that happen).

Code items:

prints cluster informations - information is singular and plural, you can drop the s

listLables should be listNodeLabels (we've gone to that everywhere b/c there will likely be
other kinds of labels, we should stay consistent, especially as "cluster" cmd name has lost
any notion of "nodelabelness")

//Make it protected to make unit test can change it
Can't we use the visible for test annotation?

It looks like the test is still using the node-labels command instead of cluster, did something
go wrong with the patch (maybe forgot to restage)?  Can you make sure the unit test + patch
code are consistent and the tests pass?

> Create yarn cluster CLI to enable list node labels collection
> -------------------------------------------------------------
>                 Key: YARN-2786
>                 URL: https://issues.apache.org/jira/browse/YARN-2786
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, client, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-2786-20141031-1.patch, YARN-2786-20141031-2.patch, YARN-2786-20141102-2.patch,
> With YARN-2778, we can list node labels on existing RM nodes. But it is not enough, we
should be able to: 
> 1) list node labels collection
> The command should start with "yarn cluster ...", in the future, we can add more functionality
to the "yarnClusterCLI"

This message was sent by Atlassian JIRA

View raw message