hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "zhihai xu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager
Date Fri, 07 Nov 2014 19:11:34 GMT

    [ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202491#comment-14202491
] 

zhihai xu commented on YARN-2753:
---------------------------------

Hi [~leftnoteasy],
Good finding, addressed your comment in the new patch YARN-2753.008.patch.
thanks
zhihai


> Fix potential issues and code clean up for *NodeLabelsManager
> -------------------------------------------------------------
>
>                 Key: YARN-2753
>                 URL: https://issues.apache.org/jira/browse/YARN-2753
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>         Attachments: YARN-2753.000.patch, YARN-2753.001.patch, YARN-2753.002.patch, YARN-2753.003.patch,
YARN-2753.004.patch, YARN-2753.005.patch, YARN-2753.006.patch, YARN-2753.007.patch, YARN-2753.008.patch
>
>
> Issues include:
> * CommonNodeLabelsManager#addToCluserNodeLabels should not change the value in labelCollections
if the key already exists otherwise the Label.resource will be changed(reset).
> * potential NPE(NullPointerException) in checkRemoveLabelsFromNode of CommonNodeLabelsManager.
> ** because when a Node is created, Node.labels can be null.
> ** In this case, nm.labels; may be null. So we need check originalLabels not null before
use it(originalLabels.containsAll).
> * addToCluserNodeLabels should be protected by writeLock in RMNodeLabelsManager.java.
because we should protect labelCollections in RMNodeLabelsManager.
> * Fix a potential bug in CommonsNodeLabelsManager, after serviceStop(...) is invoked,
some event may not be processed, see [comment|https://issues.apache.org/jira/browse/YARN-2753?focusedCommentId=14197206&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14197206]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message