hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2647) Add yarn queue CLI to get queue infos
Date Wed, 05 Nov 2014 21:27:34 GMT

    [ https://issues.apache.org/jira/browse/YARN-2647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14199117#comment-14199117
] 

Wangda Tan commented on YARN-2647:
----------------------------------

[~sunilg]l,
Two minor comments:
1)
{code}
+    pw.println("\tDefault node-label expression for this queue : " + "GPU");
+    pw.println("\tAccessible node-labels from this queue : " + "JDK_7,GPU");
{code}
I think you can remove "for this queue" and "from this queue" here, since we use a "\t" indent
to make user can understand all following content are belongs to this queue
To keep style consistent with already existed CLIs, I suggest to use "Default-Node-Label-Expression"
and "Accessible-Node-Labels", as same as others. In another word, add a "-" between words
and keep first letter upper case.

2)
Add a test for queue without setting expression and labels (to make sure we properly addressed
such cases properly).

Thanks,
Wangda


> Add yarn queue CLI to get queue infos
> -------------------------------------
>
>                 Key: YARN-2647
>                 URL: https://issues.apache.org/jira/browse/YARN-2647
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client
>            Reporter: Wangda Tan
>            Assignee: Sunil G
>         Attachments: 0001-YARN-2647.patch, 0002-YARN-2647.patch, 0003-YARN-2647.patch,
0004-YARN-2647.patch, 0005-YARN-2647.patch, 0006-YARN-2647.patch, 0007-YARN-2647.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message