hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Naganarasimha G R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2495) Allow admin specify labels from each NM (Distributed configuration)
Date Sat, 22 Nov 2014 15:48:34 GMT

    [ https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222009#comment-14222009

Naganarasimha G R commented on YARN-2495:

Hi [~wangda], Thanks for the review
bq. 1) As same as ResourceTrackerService, it's better to have a field like isDecentralizedNodeLabelConfigurationEnabled
(or some other name you like) in NodeStatusUpdaterImpl. Should be more clear than statement
Earlier in one of your [comment|https://issues.apache.org/jira/browse/YARN-2495?focusedCommentId=14183135&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14183135],
you had mentioned as 
5) NodeStatusUpdaterImpl:
isDecentralizedNodeLabelsConf may not need here, if nodeLablesProvider passed in is null.
That means isDecentralizedNodeLabelsConf is false.
+            nodeLabelsForHeartBeat = null;
+            if (isDecentralizedNodeLabelsConf) {
so had changed it , may be earlier you meant some thing else and i read the comment wrongly

for 2 & 3 will rework and share the patch, but hope test cases are fine too ?

> Allow admin specify labels from each NM (Distributed configuration)
> -------------------------------------------------------------------
>                 Key: YARN-2495
>                 URL: https://issues.apache.org/jira/browse/YARN-2495
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Naganarasimha G R
>         Attachments: YARN-2495.20141023-1.patch, YARN-2495.20141024-1.patch, YARN-2495.20141030-1.patch,
YARN-2495.20141031-1.patch, YARN-2495.20141119-1.patch, YARN-2495_20141022.1.patch
> Target of this JIRA is to allow admin specify labels in each NM, this covers
> - User can set labels in each NM (by setting yarn-site.xml or using script suggested
by [~aw])
> - NM will send labels to RM via ResourceTracker API
> - RM will set labels in NodeLabelManager when NM register/update labels

This message was sent by Atlassian JIRA

View raw message