hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Naganarasimha G R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2301) Improve yarn container command
Date Wed, 19 Nov 2014 09:59:35 GMT

    [ https://issues.apache.org/jira/browse/YARN-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217671#comment-14217671
] 

Naganarasimha G R commented on YARN-2301:
-----------------------------------------

Hi [~jianhe],
Thanks for reviewing, but required more clarifications :
 bq. we can just use containerReport.getFinishTime(), as it internally is checking “>0”
already.
 This modification is to support for the 3 issue which you mentioned {{3. finish-time is 0
if container is not yet finished. May be "N/A"}} and dint get where exactly ">0" is being
checked internally as there are no checks in PBImpl.  Can you please provide more precisely
where this check is done internally?
 bq. the scheme could be https also, we should use WebAppUtils#getHttpSchemePrefix
 Due to the following reasons i kept scheme hard coded to http
 1. We get the containers HTTP address only and to that we appending the scheme {{WebAppUtils.getRunningLogURL(container.getNodeHttpAddress()}}.
so irrespective of what scheme we set, the port will be node's http port where this container
ran. so it would not be ideal to set scheme as HTTPS and node's http port. And if we need
to correct this then we need to enforce Container.newInstance to take https url also 
 which will impact lot of places 
 2. WebAppUtils#getHttpSchemePrefix requires configuration object, so as the reference is
not available in RMContainerImpl, i need to create new YARNConfigurations RMContainerImpl
constructor and keep it. ??may be trivial issue??

so kept the changes simple. Please provide your opinion for the same

> Improve yarn container command
> ------------------------------
>
>                 Key: YARN-2301
>                 URL: https://issues.apache.org/jira/browse/YARN-2301
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Jian He
>            Assignee: Naganarasimha G R
>              Labels: usability
>         Attachments: YARN-2301.01.patch, YARN-2301.03.patch, YARN-2303.patch
>
>
> While running yarn container -list <Application Attempt ID> command, some observations:
> 1) the scheme (e.g. http/https  ) before LOG-URL is missing
> 2) the start-time is printed as milli seconds (e.g. 1405540544844). Better to print as
time format.
> 3) finish-time is 0 if container is not yet finished. May be "N/A"
> 4) May have an option to run as yarn container -list <appId> OR  yarn application
-list-containers <appId> also.  
> As attempt Id is not shown on console, this is easier for user to just copy the appId
and run it, may  also be useful for container-preserving AM restart. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message