hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1984) LeveldbTimelineStore does not handle db exceptions properly
Date Mon, 24 Nov 2014 16:00:14 GMT

    [ https://issues.apache.org/jira/browse/YARN-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223079#comment-14223079
] 

Jason Lowe commented on YARN-1984:
----------------------------------

Thanks for picking this up, Varun.

getStartTimeLong can leak the runtime DBException and shouldn't.

Is there a reason to have deleteNextEntity throw DBException rather than IOException?  It
would be cleaner for callers if deleteNextEnttiy handled this.

loadVersion can leak the runtime DBException



> LeveldbTimelineStore does not handle db exceptions properly
> -----------------------------------------------------------
>
>                 Key: YARN-1984
>                 URL: https://issues.apache.org/jira/browse/YARN-1984
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 2.4.0
>            Reporter: Jason Lowe
>            Assignee: Varun Saxena
>             Fix For: 2.7.0
>
>         Attachments: YARN-1984.patch
>
>
> The org.iq80.leveldb.DB and DBIterator methods throw runtime exceptions rather than IOException
which can easily leak up the stack and kill threads (e.g.: the deletion thread).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message