Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5350E17A52 for ; Mon, 20 Oct 2014 23:28:34 +0000 (UTC) Received: (qmail 56291 invoked by uid 500); 20 Oct 2014 23:28:34 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 56199 invoked by uid 500); 20 Oct 2014 23:28:34 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 55905 invoked by uid 99); 20 Oct 2014 23:28:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Oct 2014 23:28:34 +0000 Date: Mon, 20 Oct 2014 23:28:33 +0000 (UTC) From: "Subru Krishnan (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-2690) Make ReservationSystem and its dependent classes independent of Scheduler type MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177647#comment-14177647 ] Subru Krishnan commented on YARN-2690: -------------------------------------- Thanks [~adhoot] for updating the patch. +1 from my side. Couple of minor nits: * We could have a protected _ReservationSchedulerConfiguration_ variable in _AbstractReservationSystem_ to avoid invoking _ReservationSchedulerConfiguration reservationConfig = getReservationSchedulerConfiguration()_ everywhere. * It'll be good to have some Javadocs for _ReservationSchedulerConfiguration_ describing what the reservation system configs are. > Make ReservationSystem and its dependent classes independent of Scheduler type > -------------------------------------------------------------------------------- > > Key: YARN-2690 > URL: https://issues.apache.org/jira/browse/YARN-2690 > Project: Hadoop YARN > Issue Type: Sub-task > Components: fairscheduler > Reporter: Anubhav Dhoot > Assignee: Anubhav Dhoot > Attachments: YARN-2690.001.patch, YARN-2690.002.patch, YARN-2690.002.patch > > > A lot of common reservation classes depend on CapacityScheduler and specifically its configuration. This jira is to make them ready for other Schedulers by abstracting out the configuration. -- This message was sent by Atlassian JIRA (v6.3.4#6332)