Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Thu, 9 Oct 2014 22:30:34 +0000 (UTC)
From: "Vinod Kumar Vavilapalli (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12738745.1409734320000.232351.1412893834901@Atlassian.JIRA>
In-Reply-To: <JIRA.12738745.1409734320000@Atlassian.JIRA>
References: <JIRA.12738745.1409734320000@Atlassian.JIRA>
 <JIRA.12738745.1409734320925@arcas>
Subject: [jira] [Commented] (YARN-2494) [YARN-796] Node label manager API
 and storage implementations
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/YARN-2494?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D14165=
887#comment-14165887 ]=20

Vinod Kumar Vavilapalli commented on YARN-2494:
-----------------------------------------------

This is very close. Final set of comments:
 - The pattern {quote}^[0-9a-zA-Z][0-9a-zA-z-_]* : ^[0-9a-zA-Z][0-9a-zA-z-_=
]*{quote} has a bug: small z instead of big Z
 - LabelType, HostType, QueueType, NodeType -> Drop the Type suffix
 - Move QueueType into DynamicNodeLabelsManager.
 - DynamicNodeLabelManager=20
    -- updateRunningNodes: No need to call getNMInNodeSet twice
    -- updateRunningNodes -> updatingResourceMappings
    -- QueueType.labels -> accessibleLabels
    -- Move acls also into the RMNodeLabelsManager
 - NodeLabelsManager -> CommonNodeLabelsManager
 - DynamicNodeLabelManager -> RMNodeLabelManager. Similarly TestDynamicNode=
LabelsManager.
 - Let=E2=80=99s rename events like AddToClusterNodeLabelsEvent and store o=
perations similar to RMStateStore. For e.g. storeNewClusterNodeLables

{quote}
      // if here, nm is still null, the only reason is, registered nodeId h=
as
      // port =3D 0. This will only happen in unit test. Some tests registe=
red NM
      // with port =3D 0. Just print a log and skip following step
      if (null =3D=3D nm) {
        LOG.warn("Register nodeId is illegal, nodeId=3D" + nodeId.toString(=
));
        return;
      }
{quote}
That doesn't make sense. Any activated node will have a non-zero port.

> [YARN-796] Node label manager API and storage implementations
> -------------------------------------------------------------
>
>                 Key: YARN-2494
>                 URL: https://issues.apache.org/jira/browse/YARN-2494
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-2494.patch, YARN-2494.patch, YARN-2494.patch, Y=
ARN-2494.patch, YARN-2494.patch, YARN-2494.patch, YARN-2494.patch, YARN-249=
4.patch
>
>
> This JIRA includes APIs and storage implementations of node label manager=
,
> NodeLabelManager is an abstract class used to manage labels of nodes in t=
he cluster, it has APIs to query/modify
> - Nodes according to given label
> - Labels according to given hostname
> - Add/remove labels
> - Set labels of nodes in the cluster
> - Persist/recover changes of labels/labels-on-nodes to/from storage
> And it has two implementations to store modifications
> - Memory based storage: It will not persist changes, so all labels will b=
e lost when RM restart
> - FileSystem based storage: It will persist/recover to/from FileSystem (l=
ike HDFS), and all labels and labels-on-nodes will be recovered upon RM res=
tart


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)