hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2789) Re-instate the NodeReport.newInstance API modified in YARN-2698
Date Fri, 31 Oct 2014 19:44:34 GMT

    [ https://issues.apache.org/jira/browse/YARN-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14192336#comment-14192336
] 

Hadoop QA commented on YARN-2789:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12678527/YARN-2789-20141031-1.patch
  against trunk revision f1a149e.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/5666//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5666//console

This message is automatically generated.

> Re-instate the NodeReport.newInstance API modified in YARN-2698
> ---------------------------------------------------------------
>
>                 Key: YARN-2789
>                 URL: https://issues.apache.org/jira/browse/YARN-2789
>             Project: Hadoop YARN
>          Issue Type: Task
>            Reporter: Siddharth Seth
>            Assignee: Wangda Tan
>            Priority: Critical
>         Attachments: YARN-2789-20141031-1.patch
>
>
> Even though this is a private API, it will be used by downstream projects for testing.
It'll be useful for this to be re-instated, maybe with a deprecated annotation, so that older
versions of downstream projects can build against Hadoop 2.6.
> create() being private is a problem for multiple other classes - ContainerId, AppId etc,
Container, NodeId ... Most classes on the client facing YARN APIs are likely to be required
for testing in downstream projects.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message