hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhijie Shen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2772) DistributedShell's timeline related options are not clear
Date Thu, 30 Oct 2014 00:36:34 GMT

    [ https://issues.apache.org/jira/browse/YARN-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14189384#comment-14189384
] 

Zhijie Shen commented on YARN-2772:
-----------------------------------

[~vinodkv], thanks for your proposal.

1. I prefer "create_timeline_domain" over "should_create_timeline_domain", as it is an option
without arg. So there will not be true/false for it.

2. I'd like to enforce the validation logic (see the existing code comment). However, as we're
lacking timeline client query APIs. It will involve more steps to send http requests and parse
JSON response. I prefer to do it after YARN-2423.
{code}
    try {
      //TODO: we need to check and combine the existing timeline domain ACLs,
      //but let's do it once we have client java library to query domains.
      TimelineDomain domain = new TimelineDomain();
{code}

Otherwise, I've addressed the other comments and made a patch.

> DistributedShell's timeline related options are not clear
> ---------------------------------------------------------
>
>                 Key: YARN-2772
>                 URL: https://issues.apache.org/jira/browse/YARN-2772
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications/distributed-shell
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Zhijie Shen
>
> The new options "domain" and "create" options - they are not descriptive at all. It is
also not clear when view_acls and modify_acls need to be set.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message