hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2756) use static variable (Resources.none()) for not-running Node.resource in CommonNodeLabelsManager to save memory.
Date Tue, 28 Oct 2014 02:11:34 GMT

    [ https://issues.apache.org/jira/browse/YARN-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14186236#comment-14186236
] 

Hadoop QA commented on YARN-2756:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12677441/YARN-2756.000.patch
  against trunk revision a16d022.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new or modified
test files.

      {color:red}-1 javac{color}.  The applied patch generated 1266 javac compiler warnings
(more than the trunk's current 1265 warnings).

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs:

org.apache.hadoop.hdfs.TestLeaseRecovery2

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/5588//testReport/
Javac warnings: https://builds.apache.org/job/PreCommit-YARN-Build/5588//artifact/patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5588//console

This message is automatically generated.

> use static variable (Resources.none()) for not-running Node.resource in CommonNodeLabelsManager
to save memory.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2756
>                 URL: https://issues.apache.org/jira/browse/YARN-2756
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>            Priority: Minor
>         Attachments: YARN-2756.000.patch
>
>
> use static variable (Resources.none()) for not-running Node.resource in CommonNodeLabelsManager
to save memory. When a Node is not activated, the resource is never used, When a Node is activated,
a new resource will be assigned to it in RMNodeLabelsManager#activateNode (nm.resource = resource)
So it would be better to use static variable Resources.none() instead of allocating a new
variable(Resource.newInstance(0, 0)) for each node deactivation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message