hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager
Date Tue, 28 Oct 2014 17:08:34 GMT

     [ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Wangda Tan updated YARN-2753:
-----------------------------
    Description: 
Issues include:

* CommonNodeLabelsManager#addToCluserNodeLabels should not change the value in labelCollections
if the key already exists otherwise the Label.resource will be changed(reset).
* potential NPE(NullPointerException) in checkRemoveLabelsFromNode of CommonNodeLabelsManager.
** because when a Node is created, Node.labels can be null.
** In this case, nm.labels; may be null. So we need check originalLabels not null before use
it(originalLabels.containsAll).

  was:
CommonNodeLabelsManager#addToCluserNodeLabels should not change the value in labelCollections
if the key already exists otherwise the Label.resource will be changed(reset).

potential NPE(NullPointerException) in checkRemoveLabelsFromNode of CommonNodeLabelsManager.
because when a Node is created, Node.labels can be null.
In this case, nm.labels; may be null.
So we need check originalLabels not null before use it(originalLabels.containsAll).


> Fix potential issues and code clean up for *NodeLabelsManager
> -------------------------------------------------------------
>
>                 Key: YARN-2753
>                 URL: https://issues.apache.org/jira/browse/YARN-2753
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>         Attachments: YARN-2753.000.patch, YARN-2753.001.patch, YARN-2753.002.patch, YARN-2753.003.patch
>
>
> Issues include:
> * CommonNodeLabelsManager#addToCluserNodeLabels should not change the value in labelCollections
if the key already exists otherwise the Label.resource will be changed(reset).
> * potential NPE(NullPointerException) in checkRemoveLabelsFromNode of CommonNodeLabelsManager.
> ** because when a Node is created, Node.labels can be null.
> ** In this case, nm.labels; may be null. So we need check originalLabels not null before
use it(originalLabels.containsAll).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message