hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2753) potential NPE in checkRemoveLabelsFromNode of CommonNodeLabelsManager
Date Tue, 28 Oct 2014 00:37:34 GMT

    [ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14186125#comment-14186125
] 

Hadoop QA commented on YARN-2753:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12677455/YARN-2753.001.patch
  against trunk revision 00b4e44.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/5591//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5591//console

This message is automatically generated.

> potential NPE in checkRemoveLabelsFromNode of CommonNodeLabelsManager
> ---------------------------------------------------------------------
>
>                 Key: YARN-2753
>                 URL: https://issues.apache.org/jira/browse/YARN-2753
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>         Attachments: YARN-2753.000.patch, YARN-2753.001.patch
>
>
> potential NPE(NullPointerException) in checkRemoveLabelsFromNode of CommonNodeLabelsManager.
> It because when a Node is created, Node.labels can be null.
> In this case, nm.labels; may be null.
> So we need check originalLabels not null before use it(originalLabels.containsAll).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message