hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2726) CapacityScheduler should explicitly log when an accessible label has no capacity
Date Wed, 22 Oct 2014 21:51:34 GMT

    [ https://issues.apache.org/jira/browse/YARN-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14180594#comment-14180594
] 

Wangda Tan commented on YARN-2726:
----------------------------------

[~tweek], good suggestion! I completely agree to make error message more clear to admin/user.

> CapacityScheduler should explicitly log when an accessible label has no capacity
> --------------------------------------------------------------------------------
>
>                 Key: YARN-2726
>                 URL: https://issues.apache.org/jira/browse/YARN-2726
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: capacityscheduler
>            Reporter: Phil D'Amore
>            Assignee: Naganarasimha G R
>            Priority: Minor
>
> Given:
> - Node label defined: test-label
> - Two queues defined: a, b
> - label accessibility and and capacity defined as follows (properties abbreviated for
readability):
> root.a.accessible-node-labels = test-label
> root.a.accessible-node-labels.test-label.capacity = 100
> If you restart the RM or do a 'rmadmin -refreshQueues' you will get a stack trace with
the following error buried within:
> "Illegal capacity of -1.0 for label=test-label in queue=root.b"
> This of course occurs because test-label is accessible to b due to inheritance from the
root, and -1 is the UNDEFINED value.  To my mind this might not be obvious to the admin, and
the error message which results does not help guide someone to the source of the issue.
> I propose that this situation be updated so that when the capacity on an accessible label
is undefined, it is explicitly called out instead of falling through to the illegal capacity
check.  Something like:
> {code}
> if (capacity == UNDEFINED) {
>     throw new IllegalArgumentException("Configuration issue: " + " label=" + label +
" is accessible from queue=" + queue + " but has no capacity set.");
> }
> {code}
> I'll leave it to better judgement than mine as to whether I'm throwing the appropriate
exception there.  I think this check should be added to both getNodeLabelCapacities and getMaximumNodeLabelCapacities
in CapacitySchedulerConfiguration.java.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message