hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2723) rmadmin -replaceLabelsOnNode does not correctly parse port
Date Sun, 26 Oct 2014 11:51:40 GMT

    [ https://issues.apache.org/jira/browse/YARN-2723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184467#comment-14184467
] 

Hudson commented on YARN-2723:
------------------------------

SUCCESS: Integrated in Hadoop-Yarn-trunk #724 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/724/])
YARN-2723. Fix rmadmin -replaceLabelsOnNode does not correctly parse (xgong: rev 65d95b1a520d4ffdf024dbdfcf11d855a3948056)
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
* hadoop-yarn-project/CHANGES.txt
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java


> rmadmin -replaceLabelsOnNode does not correctly parse port
> ----------------------------------------------------------
>
>                 Key: YARN-2723
>                 URL: https://issues.apache.org/jira/browse/YARN-2723
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client
>            Reporter: Phil D'Amore
>            Assignee: Naganarasimha G R
>             Fix For: 2.6.0
>
>         Attachments: YARN-2723.20141023.1.patch, yarn-2723.20141023.2.patch
>
>
> There is an off-by-one issue in RMAdminCLI.java (line 457):
> port = Integer.valueOf(nodeIdStr.substring(nodeIdStr.indexOf(":")));
> should probably be:
> port = Integer.valueOf(nodeIdStr.substring(nodeIdStr.indexOf(":")+1));
> Currently attempting to add a label to a node with a port specified looks like this:
> [yarn@ip-10-0-0-66 ~]$ yarn rmadmin -replaceLabelsOnNode node.example.com:45454,test-label
> replaceLabelsOnNode: For input string: ":45454"
> Usage: yarn rmadmin [-replaceLabelsOnNode [node1:port,label1,label2 node2:port,label1,label2]]
> It appears to be trying to parse the ':' as part of the integer because the substring
index is off.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message