hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2707) Potential null dereference in FSDownload
Date Fri, 31 Oct 2014 22:46:34 GMT

    [ https://issues.apache.org/jira/browse/YARN-2707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14192663#comment-14192663
] 

Jason Lowe commented on YARN-2707:
----------------------------------

+1 lgtm.  Committing this.

> Potential null dereference in FSDownload
> ----------------------------------------
>
>                 Key: YARN-2707
>                 URL: https://issues.apache.org/jira/browse/YARN-2707
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Gera Shegalov
>            Priority: Minor
>         Attachments: YARN-2707.v01.patch
>
>
> Here is related code in call():
> {code}
>       Pattern pattern = null;
>       String p = resource.getPattern();
>       if (p != null) {
>         pattern = Pattern.compile(p);
>       }
>       unpack(new File(dTmp.toUri()), new File(dFinal.toUri()), pattern);
> {code}
> In unpack():
> {code}
>         RunJar.unJar(localrsrc, dst, pattern);
> {code}
> unJar() would dereference the pattern without checking whether it is null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message