hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2698) Move getClusterNodeLabels and getNodeToLabels to YARN CLI instead of RMAdminCLI
Date Wed, 29 Oct 2014 20:19:35 GMT

    [ https://issues.apache.org/jira/browse/YARN-2698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14188925#comment-14188925
] 

Wangda Tan commented on YARN-2698:
----------------------------------

Hi [~vinodkv],
bq. YarnClient usually has simpler APIs (like returning a map) instead of directly exposing
the response objects, let’s do that.
Addressed
bq. bin/yarn needs to be updated to use the new CLI
Addressed
bq. Overall, I didn’t realize we already have a node CLI already: Let’s just move the
node to labels mappings to that CLI. We could keep the all-nodes mapping though.
The node CLI is major get labels from NodeReport, they're all running NMs, I suggest to keep
node to labels mapping in node-labels CLI (as its name), and in the future we can add a "labels"
field in NodeReport and nodeCLI
bq. “will return all labels in the cluster” -> “will return all accessible labels
in the cluster”
I changed it to be ".. return all node labels" to make it consistent with java API names,
please let me know if you disagree
bq. CLI for "node-labels -list” should drop the prefix “Node-labels=“
Addressed
bq. CLI for “node-labels -list -nodeId all”: Say Node instead of Host? And then simply
make it “Node:nm:5432 -> label1, label2”
Addressed
bq. Move the node-cli tests into their own TestNodeLabelsCLI
Addressed
bq. Validate the help message for the new CLI.
Addressed 



> Move getClusterNodeLabels and getNodeToLabels to YARN CLI instead of RMAdminCLI
> -------------------------------------------------------------------------------
>
>                 Key: YARN-2698
>                 URL: https://issues.apache.org/jira/browse/YARN-2698
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, client, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>            Priority: Critical
>         Attachments: YARN-2698-20141028-1.patch, YARN-2698-20141028-2.patch, YARN-2698-20141028-3.patch,
YARN-2698-20141029-1.patch, YARN-2698-20141029-2.patch
>
>
> YARN RMAdminCLI and AdminService should have write API only, for other read APIs, they
should be located at YARNCLI and RMClientService.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message