hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2500) [YARN-796] Miscellaneous changes in ResourceManager to support labels
Date Mon, 06 Oct 2014 20:13:35 GMT

    [ https://issues.apache.org/jira/browse/YARN-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14160858#comment-14160858
] 

Wangda Tan commented on YARN-2500:
----------------------------------

Regarding comments from [~vinodkv],
bq. As with other patches, Labels -> NodeLabels. You'll need to change all of the following:...
Addressed
bq. ApplicationMasterService: There are multiple this.rmContext.getRMApps().get(appAttemptId.getApplicationId()
calls in the the allocate method. Refactor to avoid dup calls.
Addressed
bq. TestSchedulerUtils: testValidateResourceRequestWithErrorLabelsPermission: Why are "" and
" " accepted when only x and y are recognized labels?
Empty label expression "" should be accept by any queue, and " " will be trimmed to empty.
bq. Given we don't support yet other features in ResourceRequest for the AM container like
priority, locality, shall we also hard-code them to AM_CONTAINER_PRIORITY, ResourceRequest.ANY
respectively too?
Agree, now set values to default for priority/#container/resource-name/relax-locality
bq. Can we add test-case for num-containers, priority, locality for AM container?
Added test "testScheduleTransitionReplaceAMContainerRequestWithDefaults" in RMAppAttemptImpl.

Please kindly review,

Thanks,
Wangda

> [YARN-796] Miscellaneous changes in ResourceManager to support labels
> ---------------------------------------------------------------------
>
>                 Key: YARN-2500
>                 URL: https://issues.apache.org/jira/browse/YARN-2500
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-2500.patch, YARN-2500.patch, YARN-2500.patch, YARN-2500.patch,
YARN-2500.patch
>
>
> This patches contains changes in ResourceManager to support labels



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message