hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "bc Wong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2194) Add Cgroup support for RedHat 7
Date Mon, 27 Oct 2014 16:50:35 GMT

    [ https://issues.apache.org/jira/browse/YARN-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14185368#comment-14185368

bc Wong commented on YARN-2194:

* L1188: If initialize_user() fails, do you not need to cleanup?
* L1194: Same for create_log_dirs(). Seems that goto cleanup is still warranted.
* L1207: Missing space before S_IRWXU.
* L1243: Nit. Hardcoding 55 here is error-prone. You could allocate a 4K buffer here, and
use snprintf.
* L1244: You need to check the return value from malloc(). Since you're running as root here,
everything has to be extra careful.
* L1255: On failure, would log the command being executed.

> Add Cgroup support for RedHat 7
> -------------------------------
>                 Key: YARN-2194
>                 URL: https://issues.apache.org/jira/browse/YARN-2194
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Wei Yan
>            Assignee: Wei Yan
>         Attachments: YARN-2194-1.patch
> In previous versions of RedHat, we can build custom cgroup hierarchies with use of the
cgconfig command from the libcgroup package. From RedHat 7, package libcgroup is deprecated
and it is not recommended to use it since it can easily create conflicts with the default
cgroup hierarchy. The systemd is provided and recommended for cgroup management. We need to
add support for this.

This message was sent by Atlassian JIRA

View raw message