Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 314EF11346 for ; Wed, 24 Sep 2014 19:07:36 +0000 (UTC) Received: (qmail 34199 invoked by uid 500); 24 Sep 2014 19:07:34 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 34155 invoked by uid 500); 24 Sep 2014 19:07:34 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 34142 invoked by uid 99); 24 Sep 2014 19:07:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Sep 2014 19:07:34 +0000 Date: Wed, 24 Sep 2014 19:07:34 +0000 (UTC) From: "Zhijie Shen (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-2581) NMs need to find a way to get LogAggregationContext MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-2581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146742#comment-14146742 ] Zhijie Shen commented on YARN-2581: ----------------------------------- It looks good to me overall. Just some nits. 1. Can't we let this.logAggregationContext = logContextData? {code} + LogAggregationContextPBImpl logContextData = + new LogAggregationContextPBImpl( + LogAggregationContextProto.parseFrom(bytes)); + this.logAggregationContext = + LogAggregationContext.newInstance(logContextData.getIncludePattern(), + logContextData.getExcludePattern(), + logContextData.getRollingIntervalSeconds()); {code} 2. Can the following {code} + Assert.assertEquals(returned.getIncludePattern(), "includePattern"); + Assert.assertEquals(returned.getExcludePattern(), "excludePattern"); + Assert.assertTrue(returned.getRollingIntervalSeconds() == interval); {code} be changed to {code} + Assert.assertEquals("includePattern", returned.getIncludePattern()); + Assert.assertEquals("excludePattern", returned.getExcludePattern()); + Assert.assertEquals(interval, returned.getRollingIntervalSeconds()); {code} Though it makes no difference when assertion passes, it could show accurate error when assertion fails. [~vinodkv], do you want to have a look at it too? > NMs need to find a way to get LogAggregationContext > --------------------------------------------------- > > Key: YARN-2581 > URL: https://issues.apache.org/jira/browse/YARN-2581 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager, resourcemanager > Reporter: Xuan Gong > Assignee: Xuan Gong > Attachments: YARN-2581.1.patch, YARN-2581.2.patch, YARN-2581.3.patch > > > After YARN-2569, we have LogAggregationContext for application in ApplicationSubmissionContext. NMs need to find a way to get this information. > We have this requirement: For all containers in the same application should honor the same LogAggregationContext. -- This message was sent by Atlassian JIRA (v6.3.4#6332)