hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "zhihai xu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2534) FairScheduler: totalMaxShare is not calculated correctly in computeSharesInternal
Date Thu, 11 Sep 2014 03:44:33 GMT

    [ https://issues.apache.org/jira/browse/YARN-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129582#comment-14129582
] 

zhihai xu commented on YARN-2534:
---------------------------------

I uploaded a patch YARN-2534.000.patch for review.
I added a test case in this patch to prove this issue exit:
Two queues: QueueA's maxShare is 1073741824 and QueueB's  maxShare is 1073741824,
the sum of two maxShare is more than Integer.MAX_VALUE.
Without the fix, the test will fail.

> FairScheduler: totalMaxShare is not calculated correctly in computeSharesInternal
> ---------------------------------------------------------------------------------
>
>                 Key: YARN-2534
>                 URL: https://issues.apache.org/jira/browse/YARN-2534
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: scheduler
>    Affects Versions: 2.5.0
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>             Fix For: 2.6.0
>
>         Attachments: YARN-2534.000.patch
>
>
> FairScheduler: totalMaxShare is not calculated correctly in computeSharesInternal for
some cases.
> If the sum of MAX share of all Schedulables is more than Integer.MAX_VALUE ,but each
individual MAX share is not equal to Integer.MAX_VALUE. then totalMaxShare will be a negative
value, which will cause all fairShare are wrongly calculated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message