hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhijie Shen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2527) NPE in ApplicationACLsManager
Date Mon, 29 Sep 2014 23:08:35 GMT

    [ https://issues.apache.org/jira/browse/YARN-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152486#comment-14152486
] 

Zhijie Shen commented on YARN-2527:
-----------------------------------

The patch almost looks good to me, in particular the additional test cases for ApplicationACLsManager.
Just one nit:

1. The logic here is a bit counter-intuitive. Can we just assign acls.get(applicationAccessType)
to applicationACL only when it is not null?
{code}
      applicationACL = acls.get(applicationAccessType);
      if (applicationACL == null) {
        if (LOG.isDebugEnabled()) {
          LOG.debug("ACL not found for access-type " + applicationAccessType
              + " for application " + applicationId + " owned by "
              + applicationOwner + ". Using default ["
              + YarnConfiguration.DEFAULT_YARN_APP_ACL + "]");
        }
        applicationACL = DEFAULT_YARN_APP_ACL;
{code}

> NPE in ApplicationACLsManager
> -----------------------------
>
>                 Key: YARN-2527
>                 URL: https://issues.apache.org/jira/browse/YARN-2527
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.5.0
>            Reporter: Benoy Antony
>            Assignee: Benoy Antony
>         Attachments: YARN-2527.patch, YARN-2527.patch
>
>
> NPE in _ApplicationACLsManager_ can result in 500 Internal Server Error.
> The relevant stacktrace snippet from the ResourceManager logs is as below
> {code}
> Caused by: java.lang.NullPointerException
>         at org.apache.hadoop.yarn.server.security.ApplicationACLsManager.checkAccess(ApplicationACLsManager.java:104)
>         at org.apache.hadoop.yarn.server.resourcemanager.webapp.AppBlock.render(AppBlock.java:101)
>         at org.apache.hadoop.yarn.webapp.view.HtmlBlock.render(HtmlBlock.java:66)
>         at org.apache.hadoop.yarn.webapp.view.HtmlBlock.renderPartial(HtmlBlock.java:76)
>         at org.apache.hadoop.yarn.webapp.View.render(View.java:235)
> {code}
> This issue was reported by [~miguenther].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message