hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig Welch (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2494) [YARN-796] Node label manager API and storage implementations
Date Tue, 16 Sep 2014 17:31:35 GMT

    [ https://issues.apache.org/jira/browse/YARN-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135774#comment-14135774

Craig Welch commented on YARN-2494:

the only change is the (?automated) removal of an import, I think you should just drop it
from the change set.

why force all to lower case?  Discussion favored dropping that...
checks for valid labels, there must be an easier way/stringlib/regex

addNMInNodeAlreadyHasNM - what happens when the same node has multiple labels which are all
usable by a given queue?  Looks like it would be added + times

also in updateLableResource - it looks like if node1 has label a b and queue q1 has label
a b it’s resources will be added 2x and removed 2x, while present it will have a 2x value
(1x too many)

(I’m going to write a test to see, but that’s what I think might happen based on what
I see in the code)

line 603 exception message needs to include “or not present”

pls rename activeNode deactiveNode to activateNode and deactivateNode

> [YARN-796] Node label manager API and storage implementations
> -------------------------------------------------------------
>                 Key: YARN-2494
>                 URL: https://issues.apache.org/jira/browse/YARN-2494
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-2494.patch, YARN-2494.patch, YARN-2494.patch
> This JIRA includes APIs and storage implementations of node label manager,
> NodeLabelManager is an abstract class used to manage labels of nodes in the cluster,
it has APIs to query/modify
> - Nodes according to given label
> - Labels according to given hostname
> - Add/remove labels
> - Set labels of nodes in the cluster
> - Persist/recover changes of labels/labels-on-nodes to/from storage
> And it has two implementations to store modifications
> - Memory based storage: It will not persist changes, so all labels will be lost when
RM restart
> - FileSystem based storage: It will persist/recover to/from FileSystem (like HDFS), and
all labels and labels-on-nodes will be recovered upon RM restart

This message was sent by Atlassian JIRA

View raw message