hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2484) FileSystemRMStateStore#readFile/writeFile should close FSData(In|Out)putStream in final block
Date Fri, 12 Sep 2014 04:59:34 GMT

    [ https://issues.apache.org/jira/browse/YARN-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14131100#comment-14131100
] 

Hadoop QA commented on YARN-2484:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12668255/YARN-2484.2.patch
  against trunk revision d6ce269.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/4911//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4911//console

This message is automatically generated.

> FileSystemRMStateStore#readFile/writeFile should close FSData(In|Out)putStream in final
block
> ---------------------------------------------------------------------------------------------
>
>                 Key: YARN-2484
>                 URL: https://issues.apache.org/jira/browse/YARN-2484
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Tsuyoshi OZAWA
>            Assignee: Tsuyoshi OZAWA
>            Priority: Trivial
>         Attachments: YARN-2484.1.patch, YARN-2484.2.patch
>
>
> File descriptors can leak if exceptions are thrown in these methods.
> {code}
>  private byte[] readFile(Path inputPath, long len) throws Exception {
>     FSDataInputStream fsIn = fs.open(inputPath);
>     // state data will not be that "long"
>     byte[] data = new byte[(int)len];
>     fsIn.readFully(data);
>     fsIn.close();
>     return data;
>   }
> {code}
> {code}
>   private void writeFile(Path outputPath, byte[] data) throws Exception {
>     Path tempPath =
>         new Path(outputPath.getParent(), outputPath.getName() + ".tmp");
>     FSDataOutputStream fsOut = null;
>     // This file will be overwritten when app/attempt finishes for saving the
>     // final status.
>     fsOut = fs.create(tempPath, true);
>     fsOut.write(data);
>     fsOut.close();
>     fs.rename(tempPath, outputPath);
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message