hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2475) ReservationSystem: replan upon capacity reduction
Date Fri, 12 Sep 2014 16:24:34 GMT

    [ https://issues.apache.org/jira/browse/YARN-2475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14131713#comment-14131713

Chris Douglas commented on YARN-2475:

+1, other than a couple very minor nits:
* the new cstr accepting {{Clock}} can be package-private, with the no-arg cstr calling {{this(new
UTCClock());}} (comment unnecessary, or replace with {{@VisibleForTesting}})
* The unit test could have a more descriptive name than {{test()}}, declare {{PlanningException}}
in its throws clause instead of calling {{Assert::fail()}} on catching it, and not declare
{{InterruptedException}} which it no longer throws

Just a minor clarification: as this iterates over each instant of the plan, are others allowed
to modify it?

> ReservationSystem: replan upon capacity reduction
> -------------------------------------------------
>                 Key: YARN-2475
>                 URL: https://issues.apache.org/jira/browse/YARN-2475
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Carlo Curino
>            Assignee: Carlo Curino
>         Attachments: YARN-2475.patch, YARN-2475.patch
> In the context of YARN-1051, if capacity of the cluster drops significantly upon machine
failures we need to trigger a reorganization of the planned reservations. As reservations
are "absolute" it is possible that they will not all fit, and some need to be rejected a-posteriori.

This message was sent by Atlassian JIRA

View raw message