hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsuyoshi OZAWA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2312) Marking ContainerId#getId as deprecated
Date Thu, 18 Sep 2014 07:10:34 GMT

    [ https://issues.apache.org/jira/browse/YARN-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14138622#comment-14138622
] 

Tsuyoshi OZAWA commented on YARN-2312:
--------------------------------------

Basically we can replace {{getId()}} with {{getContainerId()}} straightforwardly. [~jianhe],
[~vinodkv], how can we deal with following exceptions?

1. {{WrappedJvmID}}. In TaskAttemptImpl, the id is created by using {{container.getId}}. If
we change a constructor of {{WrapperedJvmID}}, we also need to change a constructor of {{ID}}
class itself. One idea is to add {{id}} for upper 32 bits of container Id to {{ID}} class.
{code}
      taskAttempt.jvmID =
          new WrappedJvmID(taskAttempt.remoteTask.getTaskID().getJobID(),
            taskAttempt.remoteTask.isMapTask(), taskAttempt.container.getId()
              .getId());
{code}
2. {{Priority}}. Can we change the definition of Proto? It's used widely and one concern is
backward compatibility.

> Marking ContainerId#getId as deprecated
> ---------------------------------------
>
>                 Key: YARN-2312
>                 URL: https://issues.apache.org/jira/browse/YARN-2312
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Tsuyoshi OZAWA
>            Assignee: Tsuyoshi OZAWA
>
> {{ContainerId#getId}} will only return partial value of containerId, only sequence number
of container id without epoch, after YARN-2229. We should mark {{ContainerId#getId}} as deprecated
and use {{ContainerId#getContainerId}} instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message