hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2312) Marking ContainerId#getId as deprecated
Date Tue, 23 Sep 2014 13:52:34 GMT

    [ https://issues.apache.org/jira/browse/YARN-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144806#comment-14144806
] 

Jason Lowe commented on YARN-2312:
----------------------------------

Took a brief look at the new patch.  What I meant by my original comment was to not have JvmID
derive from ID at all.  It seems it's only doing so to reuse the read/write methods which
are wrong as soon as we use a long instead of an int anyway.  By leaving it a derivation of
ID, now we have a confusing "do I use getId vs. getJvmId" issue and an extra 4 bytes of storage
in ID that we don't need.

> Marking ContainerId#getId as deprecated
> ---------------------------------------
>
>                 Key: YARN-2312
>                 URL: https://issues.apache.org/jira/browse/YARN-2312
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Tsuyoshi OZAWA
>            Assignee: Tsuyoshi OZAWA
>         Attachments: YARN-2312-wip.patch, YARN-2312.1.patch
>
>
> {{ContainerId#getId}} will only return partial value of containerId, only sequence number
of container id without epoch, after YARN-2229. We should mark {{ContainerId#getId}} as deprecated
and use {{ContainerId#getContainerId}} instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message