hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1712) Admission Control: plan follower
Date Wed, 10 Sep 2014 04:12:29 GMT

    [ https://issues.apache.org/jira/browse/YARN-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128023#comment-14128023
] 

Wangda Tan commented on YARN-1712:
----------------------------------

Hi [~subru], 
I've just taken a look at your latest patch, now the code is much cleaner than before, thanks!

I'm not quite understand what you said,
bq. Tried moving the default queue creating to when PlanQueue is initialized in CapacityScheduler
but it was getting overly complex mainly due to the relaxed constraint of child capacities
<=100% for PlanQueues. This is just an additional hashmap lookup with the code being much
cleaner so not moving it for now. If it is still a concern, I can add a flag to Plan and check
that instead of CapacityScheduler#getQueue
Could you please elaborate? 

And in addition, a very minor comments is, could you put LOG.debug within block like LOG.debug
in other modules?
{code}
if (LOG.isDebugEnabled()) {
     // ...
}
{code}

Thanks,
Wangda

> Admission Control: plan follower
> --------------------------------
>
>                 Key: YARN-1712
>                 URL: https://issues.apache.org/jira/browse/YARN-1712
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler, resourcemanager
>            Reporter: Carlo Curino
>            Assignee: Carlo Curino
>              Labels: reservations, scheduler
>         Attachments: YARN-1712.1.patch, YARN-1712.2.patch, YARN-1712.3.patch, YARN-1712.patch
>
>
> This JIRA tracks a thread that continuously propagates the current state of an inventory
subsystem to the scheduler. As the inventory subsystem store the "plan" of how the resources
should be subdivided, the work we propose in this JIRA realizes such plan by dynamically instructing
the CapacityScheduler to add/remove/resize queues to follow the plan.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message