hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carlo Curino (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1711) CapacityOverTimePolicy: a policy to enforce quotas over time for YARN-1709
Date Mon, 15 Sep 2014 23:34:34 GMT

    [ https://issues.apache.org/jira/browse/YARN-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14134693#comment-14134693
] 

Carlo Curino commented on YARN-1711:
------------------------------------

[~chris.douglas] thanks for the prompt and precise feedback. 

I addressed them in the updated patch (v4) as follows:
 * added comments and implemented nits as requested
 * got rid of excludeList altogether, as this is not necessary anymore given restructuring
done in th e ReservationSystem (i.e., the exclusion list is now handled outside the scope
of the policies which is cleaner/simpler)
 * improved tests, by using subclasses of exception wherever possible, and scoping them so
that it is more "telling" that a failure is what we wanted to be.
 * subclasses of PlanningException give callers some indication of why the call did not succeed
(e.g., enough for the tests), future smarter agents might require more detailed explanation
(e.g., the JSON payload you mention)
 * used the (expected = SomeException.class) notation for tests. 

Regarding annotations I am using @Public @Unstable for the exceptions, as they can bubble
up all the way to users, while @LimitedPrivate("yarn") @Unstable for the other classes. If
anyone has better suggestions for the annotations please advise.


> CapacityOverTimePolicy: a policy to enforce quotas over time for YARN-1709
> --------------------------------------------------------------------------
>
>                 Key: YARN-1711
>                 URL: https://issues.apache.org/jira/browse/YARN-1711
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Carlo Curino
>            Assignee: Carlo Curino
>              Labels: reservations
>         Attachments: YARN-1711.1.patch, YARN-1711.2.patch, YARN-1711.3.patch, YARN-1711.patch
>
>
> This JIRA tracks the development of a policy that enforces user quotas (a time-extension
of the notion of capacity) in the inventory subsystem discussed in YARN-1709.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message