hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1709) Admission Control: Reservation subsystem
Date Fri, 12 Sep 2014 16:37:34 GMT

    [ https://issues.apache.org/jira/browse/YARN-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14131727#comment-14131727
] 

Chris Douglas commented on YARN-1709:
-------------------------------------

Thanks for the updates. Just a few minor tweaks, then I'm +1
* In checking the preconditions:
{code}
if (!readWriteLock.isWriteLockedByCurrentThread()) {
  return;
}
{code}
The intent was to {{assert}} and crash, so tests against this code can detect violations if
the code is modified. When assertions are disabled, the check is elided
* Instead of two cstr that assign all the final fields, the no-arg should call the other
* Instead of explicitly throwing {{ClassCastException}}, this should just attempt the cast.
The cause is implicit, and doesn't require a custom error string

> Admission Control: Reservation subsystem
> ----------------------------------------
>
>                 Key: YARN-1709
>                 URL: https://issues.apache.org/jira/browse/YARN-1709
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Carlo Curino
>            Assignee: Subramaniam Krishnan
>         Attachments: YARN-1709.patch, YARN-1709.patch, YARN-1709.patch, YARN-1709.patch,
YARN-1709.patch, YARN-1709.patch
>
>
> This JIRA is about the key data structure used to track resources over time to enable
YARN-1051. The Reservation subsystem is conceptually a "plan" of how the scheduler will allocate
resources over-time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message