hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1707) Making the CapacityScheduler more dynamic
Date Thu, 04 Sep 2014 01:08:53 GMT

    [ https://issues.apache.org/jira/browse/YARN-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120786#comment-14120786
] 

Jian He commented on YARN-1707:
-------------------------------

Subra, thanks for your update, looks good to me overall, we are almost there. just few minor
things:
- Given we have the hideReservationQueues flag, I think if we still return reserveQueue name
for the reservationQueue, it won’t be exposed. 
{code}
  @Override
  public String getDisplayName() {
    return this.getParent().getQueueName();
  }
{code}
-  the visibility may not need to be changed
{code}
-  private boolean unreserve(FiCaSchedulerApp application, Priority priority,
+  protected boolean unreserve(FiCaSchedulerApp application, Priority priority,
{code}
- why we added this null check.
{code}
if (application != null) {
        synchronized (application) {
          return assignReservedContainer(application, node, reservedContainer,
              clusterResource);
        }
      }
{code}
- I think we may pass the EntitileMent class into the changeCapacity method and update both
capacity and maxCapacity 
{code}
      newQueue.changeCapacity(entitlement.getCapacity());
      // note: we currently set maxCapacity to capacity
      // this might be revised later
      queue.setMaxCapacity(entitlement.getMaxCapacity());
{code}
- the YarnException type may not be needed
{code}
      QueueEntitlement entitlement) throws SchedulerDynamicEditException,
      YarnException {
{code}

> Making the CapacityScheduler more dynamic
> -----------------------------------------
>
>                 Key: YARN-1707
>                 URL: https://issues.apache.org/jira/browse/YARN-1707
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler
>            Reporter: Carlo Curino
>            Assignee: Carlo Curino
>              Labels: capacity-scheduler
>         Attachments: YARN-1707.2.patch, YARN-1707.3.patch, YARN-1707.4.patch, YARN-1707.5.patch,
YARN-1707.6.patch, YARN-1707.7.patch, YARN-1707.patch
>
>
> The CapacityScheduler is a rather static at the moment, and refreshqueue provides a rather
heavy-handed way to reconfigure it. Moving towards long-running services (tracked in YARN-896)
and to enable more advanced admission control and resource parcelling we need to make the
CapacityScheduler more dynamic. This is instrumental to the umbrella jira YARN-1051.
> Concretely this require the following changes:
> * create queues dynamically
> * destroy queues dynamically
> * dynamically change queue parameters (e.g., capacity) 
> * modify refreshqueue validation to enforce sum(child.getCapacity())<= 100% instead
of ==100%
> We limit this to LeafQueues. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message