Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 451AC114FB for ; Tue, 26 Aug 2014 07:20:58 +0000 (UTC) Received: (qmail 37534 invoked by uid 500); 26 Aug 2014 07:20:58 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 37479 invoked by uid 500); 26 Aug 2014 07:20:58 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 37467 invoked by uid 99); 26 Aug 2014 07:20:58 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Aug 2014 07:20:58 +0000 Date: Tue, 26 Aug 2014 07:20:58 +0000 (UTC) From: "Hadoop QA (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-2453) TestProportionalCapacityPreemptionPolicy is failed for FairScheduler MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110427#comment-14110427 ] Hadoop QA commented on YARN-2453: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12664328/YARN-2453.000.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/4731//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4731//console This message is automatically generated. > TestProportionalCapacityPreemptionPolicy is failed for FairScheduler > -------------------------------------------------------------------- > > Key: YARN-2453 > URL: https://issues.apache.org/jira/browse/YARN-2453 > Project: Hadoop YARN > Issue Type: Bug > Reporter: zhihai xu > Assignee: zhihai xu > Attachments: YARN-2453.000.patch > > > TestProportionalCapacityPreemptionPolicy is failed for FairScheduler. > The following is error message: > Running org.apache.hadoop.yarn.server.resourcemanager.monitor.capacity.TestProportionalCapacityPreemptionPolicy > Tests run: 18, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.94 sec <<< FAILURE! - in org.apache.hadoop.yarn.server.resourcemanager.monitor.capacity.TestProportionalCapacityPreemptionPolicy > testPolicyInitializeAfterSchedulerInitialized(org.apache.hadoop.yarn.server.resourcemanager.monitor.capacity.TestProportionalCapacityPreemptionPolicy) Time elapsed: 1.61 sec <<< FAILURE! > java.lang.AssertionError: Failed to find SchedulingMonitor service, please check what happened > at org.junit.Assert.fail(Assert.java:88) > at org.apache.hadoop.yarn.server.resourcemanager.monitor.capacity.TestProportionalCapacityPreemptionPolicy.testPolicyInitializeAfterSchedulerInitialized(TestProportionalCapacityPreemptionPolicy.java:469) > This test should only work for capacity scheduler because the following source code in ResourceManager.java prove it will only work for capacity scheduler. > {code} > if (scheduler instanceof PreemptableResourceScheduler > && conf.getBoolean(YarnConfiguration.RM_SCHEDULER_ENABLE_MONITORS, > YarnConfiguration.DEFAULT_RM_SCHEDULER_ENABLE_MONITORS)) { > {code} > Because CapacityScheduler is instance of PreemptableResourceScheduler and FairScheduler is not instance of PreemptableResourceScheduler. > I will upload a patch to fix this issue. -- This message was sent by Atlassian JIRA (v6.2#6252)