Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B69CC11AC8 for ; Thu, 28 Aug 2014 03:31:59 +0000 (UTC) Received: (qmail 90358 invoked by uid 500); 28 Aug 2014 03:31:59 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 90318 invoked by uid 500); 28 Aug 2014 03:31:59 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 90298 invoked by uid 99); 28 Aug 2014 03:31:59 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Aug 2014 03:31:59 +0000 Date: Thu, 28 Aug 2014 03:31:59 +0000 (UTC) From: "Ashwin Shankar (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-2395) FairScheduler: Preemption timeout should be configurable per queue MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113290#comment-14113290 ] Ashwin Shankar commented on YARN-2395: -------------------------------------- [~kasha], I'm fine with the plan. However I'm not very clear on what you plan to do in YARN-2457. I'll ping you later to discuss this. Patch looks mostly good. Couple of questions : Do we want to introduce backward incompatible change by removing the existing global "fairSharePreemptionTimeout" config ? Just curious as to why we decided to inherit timeouts ? One nit : {code} // For max share {code} This should be fair share. > FairScheduler: Preemption timeout should be configurable per queue > ------------------------------------------------------------------ > > Key: YARN-2395 > URL: https://issues.apache.org/jira/browse/YARN-2395 > Project: Hadoop YARN > Issue Type: New Feature > Components: fairscheduler > Reporter: Ashwin Shankar > Assignee: Wei Yan > Attachments: YARN-2395-1.patch, YARN-2395-2.patch, YARN-2395-3.patch, YARN-2395-3.patch > > > Currently in fair scheduler, the preemption logic considers fair share starvation only at leaf queue level. This jira is created to implement it at the parent queue as well. > It involves : > 1. Making "check for fair share starvation" and "amount of resource to preempt" recursive such that they traverse the queue hierarchy from root to leaf. > 2. Currently fairSharePreemptionTimeout is a global config. We could make it configurable on a per queue basis,so that we can specify different timeouts for parent queues. -- This message was sent by Atlassian JIRA (v6.2#6252)