Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2CB2E11A14 for ; Fri, 1 Aug 2014 04:13:40 +0000 (UTC) Received: (qmail 1196 invoked by uid 500); 1 Aug 2014 04:13:39 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 695 invoked by uid 500); 1 Aug 2014 04:13:39 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 289 invoked by uid 99); 1 Aug 2014 04:13:39 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Aug 2014 04:13:39 +0000 Date: Fri, 1 Aug 2014 04:13:39 +0000 (UTC) From: "Junping Du (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (YARN-2051) Fix code in PBimpls and add more unit tests with reflection MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junping Du updated YARN-2051: ----------------------------- Summary: Fix code in PBimpls and add more unit tests with reflection (was: Fix code bug and add more unit tests for PBImpls) > Fix code in PBimpls and add more unit tests with reflection > ----------------------------------------------------------- > > Key: YARN-2051 > URL: https://issues.apache.org/jira/browse/YARN-2051 > Project: Hadoop YARN > Issue Type: Test > Reporter: Junping Du > Assignee: Binglin Chang > Priority: Critical > Attachments: YARN-2051.v1.patch, YARN-2051.v2.patch > > > From YARN-2016, we can see some bug could exist in PB implementation of protocol. The bad news is most of these PBImpl don't have any unit test to verify the info is not lost or changed after serialization/deserialization. We should add more tests for it. -- This message was sent by Atlassian JIRA (v6.2#6252)