hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xu Yang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2454) The function compareTo of variable UNBOUNDED in org.apache.hadoop.yarn.util.resource.Resources is definited wrong.
Date Tue, 26 Aug 2014 09:09:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110525#comment-14110525
] 

Xu Yang commented on YARN-2454:
-------------------------------

[~tendo@uproadx.com], Thank you for your suggest. I genetate a new patch at root directory.
About moving these tests to org.apache.hadoop.yarn.server.resourcemanager.resource.Resources,
I think it will be strange. Whereas moving the latter to the file that I created is a better
way.

> The function compareTo of variable UNBOUNDED in org.apache.hadoop.yarn.util.resource.Resources
is definited wrong.
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2454
>                 URL: https://issues.apache.org/jira/browse/YARN-2454
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.4.0, 2.5.0, 2.4.1
>            Reporter: Xu Yang
>         Attachments: YARN-2454-patch.diff, YARN-2454.patch
>
>
> The variable UNBOUNDED implement the abstract class Resources, and override the function
compareTo. But there is something wrong in this function. We should not compare resources
with zero as the same as the variable NONE. We should change 0 to Integer.MAX_VALUE.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message