hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsuyoshi OZAWA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2454) The function compareTo of variable UNBOUNDED in org.apache.hadoop.yarn.util.resource.Resources is definited wrong.
Date Tue, 26 Aug 2014 07:02:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110415#comment-14110415
] 

Tsuyoshi OZAWA commented on YARN-2454:
--------------------------------------

Also, the first testCompareToWithNoneResource is correct. Please ignore latter one.

> The function compareTo of variable UNBOUNDED in org.apache.hadoop.yarn.util.resource.Resources
is definited wrong.
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2454
>                 URL: https://issues.apache.org/jira/browse/YARN-2454
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.4.0, 2.5.0, 2.4.1
>            Reporter: Xu Yang
>         Attachments: YARN-2454-patch.diff
>
>
> The variable UNBOUNDED implement the abstract class Resources, and override the function
compareTo. But there is something wrong in this function. We should not compare resources
with zero as the same as the variable NONE. We should change 0 to Integer.MAX_VALUE.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message