hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2395) FairScheduler: Preemption timeout should be configurable per queue
Date Fri, 29 Aug 2014 21:29:54 GMT

    [ https://issues.apache.org/jira/browse/YARN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14115854#comment-14115854
] 

Karthik Kambatla commented on YARN-2395:
----------------------------------------

Thanks for quickly updating the patch, Wei. The patch looks mostly good, a couple of minor
comments (sorry, I should have done a more thorough review earlier): 
# Instead of calling updatePreemptionTimeouts() in FairScheduler multiple times, we should
probably call it in QueueManager#updateAllocationConfiguration once where we call recomputeSteadyShares().
# Can we augment the test (or add a new one) to verify we are not breaking backward compatibility
with the preemptionTimeout defaults? 

> FairScheduler: Preemption timeout should be configurable per queue
> ------------------------------------------------------------------
>
>                 Key: YARN-2395
>                 URL: https://issues.apache.org/jira/browse/YARN-2395
>             Project: Hadoop YARN
>          Issue Type: New Feature
>          Components: fairscheduler
>            Reporter: Ashwin Shankar
>            Assignee: Wei Yan
>         Attachments: YARN-2395-1.patch, YARN-2395-2.patch, YARN-2395-3.patch, YARN-2395-3.patch,
YARN-2395-4.patch
>
>
> Currently in fair scheduler, the preemption logic considers fair share starvation only
at leaf queue level. This jira is created to implement it at the parent queue as well.
> It involves :
> 1. Making "check for fair share starvation" and "amount of resource to preempt"  recursive
such that they traverse the queue hierarchy from root to leaf.
> 2. Currently fairSharePreemptionTimeout is a global config. We could make it configurable
on a per queue basis,so that we can specify different timeouts for parent queues.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message