hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2378) Adding support for moving apps between queues in Capacity Scheduler
Date Fri, 08 Aug 2014 05:14:12 GMT

    [ https://issues.apache.org/jira/browse/YARN-2378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090314#comment-14090314
] 

Wangda Tan commented on YARN-2378:
----------------------------------

Hi [~subru],
It's good to have more test from YARN-2248, now I think it covers most cases,
Several comments about tests:
1) testMoveAppForMoveToQueueCannotRunApp:
I think the name may not be precise enough. Actually, it means moving an app from a small
queue (cannot allocate more resource) to a larger queue. I suggest you can change the name
And the comment is incorrect:
{code}
        +    // task_0_0 task_1_0 allocated, used=4G 
        +    nodeUpdate(nm_0); 
{code}
The used should = 2G here.

2) testMoveAllApps:
bq. +    Thread.sleep(100);
I think we don't need sleep here, moveApplication is a synchronized call.

Thanks,
Wangda

> Adding support for moving apps between queues in Capacity Scheduler
> -------------------------------------------------------------------
>
>                 Key: YARN-2378
>                 URL: https://issues.apache.org/jira/browse/YARN-2378
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler
>            Reporter: Subramaniam Venkatraman Krishnan
>            Assignee: Subramaniam Venkatraman Krishnan
>              Labels: capacity-scheduler
>         Attachments: YARN-2378.patch, YARN-2378.patch
>
>
> As discussed with [~leftnoteasy] and [~jianhe], we are breaking up YARN-1707 to smaller
patches for manageability. This JIRA will address adding support for moving apps between queues
in Capacity Scheduler.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message