[ https://issues.apache.org/jira/browse/YARN-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091388#comment-14091388
]
Jian He commented on YARN-2138:
-------------------------------
thanks Karthik for the review !
Varun, patch not applying on trunk any more. mind updating the patch please ?
Minor comment: noticed this seems having a tab before "RMAppAttemptEventType.ATTEMPT_UPDATE_SAVED));"
{code}
+ new RMAppAttemptEvent(applicationAttempt.getAppAttemptId(),
+ RMAppAttemptEventType.ATTEMPT_UPDATE_SAVED));
{code}
> Cleanup notifyDone* methods in RMStateStore
> -------------------------------------------
>
> Key: YARN-2138
> URL: https://issues.apache.org/jira/browse/YARN-2138
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Jian He
> Assignee: Varun Saxena
> Attachments: YARN-2138.002.patch, YARN-2138.patch
>
>
> The storedException passed into notifyDoneStoringApplication is always null. Similarly
for other notifyDone* methods. We can clean up these methods as this control flow path is
not used anymore.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
|