hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2138) Cleanup notifyDone* methods in RMStateStore
Date Thu, 07 Aug 2014 19:31:13 GMT

    [ https://issues.apache.org/jira/browse/YARN-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089669#comment-14089669
] 

Jian He commented on YARN-2138:
-------------------------------

[~varun_saxena], thanks for the effort ! 
Patch looks good overall. some styling comments:
- tabs are used before RMAppEventType.APP_NEW_SAVED));  we should use space instead. similarly
for other places.
{code}
        store.notifyApplication(new RMAppEvent(appId, 
        		RMAppEventType.APP_NEW_SAVED));     
{code}
- typically, there should be no blank spaces in the end of the line.

> Cleanup notifyDone* methods in RMStateStore
> -------------------------------------------
>
>                 Key: YARN-2138
>                 URL: https://issues.apache.org/jira/browse/YARN-2138
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Jian He
>            Assignee: Varun Saxena
>         Attachments: YARN-2138.patch
>
>
> The storedException passed into notifyDoneStoringApplication is always null. Similarly
for other notifyDone* methods. We can clean up these methods as this control flow path is
not used anymore.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message