hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Saxena (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2138) Cleanup notifyDone* methods in RMStateStore
Date Wed, 06 Aug 2014 12:20:13 GMT

    [ https://issues.apache.org/jira/browse/YARN-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087593#comment-14087593
] 

Varun Saxena commented on YARN-2138:
------------------------------------

[~jianhe], kindly review the changes made for the patch. I have made following changes :
1.  Deleted classes RMAppUpdatedSavedEvent,RMAppNewSavedEvent, RMAppAttemptNewSavedEvent and
RMAppAttemptUpdatESavedEvent as they were offering no additional functionality over and above
the base class, after removal of stored exception and updated exception.
2. Refactored code in RMStateStore and removed notifyDoneXXX methods.
3. Removed code corresponding to exception handling in RMAppImpl and RMAppAttemptImpl.
4. Made necessary changes in test cases.

> Cleanup notifyDone* methods in RMStateStore
> -------------------------------------------
>
>                 Key: YARN-2138
>                 URL: https://issues.apache.org/jira/browse/YARN-2138
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Jian He
>            Assignee: Varun Saxena
>         Attachments: YARN-2138.patch
>
>
> The storedException passed into notifyDoneStoringApplication is always null. Similarly
for other notifyDone* methods. We can clean up these methods as this control flow path is
not used anymore.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message