Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C729B11CAF for ; Fri, 18 Jul 2014 11:03:05 +0000 (UTC) Received: (qmail 20434 invoked by uid 500); 18 Jul 2014 11:03:05 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 20368 invoked by uid 500); 18 Jul 2014 11:03:05 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 20354 invoked by uid 99); 18 Jul 2014 11:03:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Jul 2014 11:03:05 +0000 Date: Fri, 18 Jul 2014 11:03:05 +0000 (UTC) From: "Varun Vasudev (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-2270) TestFSDownload#testDownloadPublicWithStatCache fails in trunk MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066272#comment-14066272 ] Varun Vasudev commented on YARN-2270: ------------------------------------- [~ajisakaa] your current patch if ok, but maybe we should skip the test if the ancestor permissions aren't right? If the real issue is the ancestor permissions, then the get() will fail for all the files. Maybe something like - {noformat} boolean ancestorPermissionsOK = FSDownload.ancestorsHaveExecutePermissions(fs, basedir, null); assumeTrue(ancestorPermissionsOK); {noformat} The benefit of this approach is that the test gets reported as skipped and people who are interested in ensuring it runs correctly can fix their build environment to ensure the test runs. Your current approach hides the fact that the test didn't really do what it was expected to do(apart from the log message). > TestFSDownload#testDownloadPublicWithStatCache fails in trunk > ------------------------------------------------------------- > > Key: YARN-2270 > URL: https://issues.apache.org/jira/browse/YARN-2270 > Project: Hadoop YARN > Issue Type: Test > Affects Versions: 2.4.1 > Reporter: Ted Yu > Assignee: Akira AJISAKA > Priority: Minor > Attachments: YARN-2270.patch > > > From https://builds.apache.org/job/Hadoop-yarn-trunk/608/console : > {code} > Running org.apache.hadoop.yarn.util.TestFSDownload > Tests run: 9, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.955 sec <<< FAILURE! - in org.apache.hadoop.yarn.util.TestFSDownload > testDownloadPublicWithStatCache(org.apache.hadoop.yarn.util.TestFSDownload) Time elapsed: 0.137 sec <<< FAILURE! > java.lang.AssertionError: null > at org.junit.Assert.fail(Assert.java:86) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertTrue(Assert.java:52) > at org.apache.hadoop.yarn.util.TestFSDownload.testDownloadPublicWithStatCache(TestFSDownload.java:363) > {code} > Similar error can be seen here: https://builds.apache.org/job/PreCommit-YARN-Build/4243//testReport/org.apache.hadoop.yarn.util/TestFSDownload/testDownloadPublicWithStatCache/ > Looks like future.get() returned null. -- This message was sent by Atlassian JIRA (v6.2#6252)