Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6B83D1101D for ; Thu, 24 Jul 2014 19:58:41 +0000 (UTC) Received: (qmail 63675 invoked by uid 500); 24 Jul 2014 19:58:40 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 63622 invoked by uid 500); 24 Jul 2014 19:58:40 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 63497 invoked by uid 99); 24 Jul 2014 19:58:40 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Jul 2014 19:58:40 +0000 Date: Thu, 24 Jul 2014 19:58:40 +0000 (UTC) From: "Xuan Gong (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-2211) RMStateStore needs to save AMRMToken master key for recovery when RM restart/failover happens MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073577#comment-14073577 ] Xuan Gong commented on YARN-2211: --------------------------------- bq. This code not needed? may remove the newInstance() method also It is used in RMStateStore initiation. bq. currentKey will never be null ? if so, we can remove the check. Might need to keep the NULL check. If the RM is start from the brand new state, there are no states at all. So, the currentKey is NULL. bq. Instead of moving the following to yarn_proto, we should probably have a separate jira to move all the RM recovery related records to resource manager module. For now, I think we can create a new proto file and move amrm token state there. We can do that. > RMStateStore needs to save AMRMToken master key for recovery when RM restart/failover happens > ---------------------------------------------------------------------------------------------- > > Key: YARN-2211 > URL: https://issues.apache.org/jira/browse/YARN-2211 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Reporter: Xuan Gong > Assignee: Xuan Gong > Attachments: YARN-2211.1.patch, YARN-2211.2.patch, YARN-2211.3.patch, YARN-2211.4.patch, YARN-2211.5.1.patch, YARN-2211.5.patch, YARN-2211.6.1.patch, YARN-2211.6.patch > > > After YARN-2208, AMRMToken can be rolled over periodically. We need to save related Master Keys and use them to recover the AMRMToken when RM restart/failover happens -- This message was sent by Atlassian JIRA (v6.2#6252)